Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2065)

Unified Diff: android_webview/BUILD.gn

Issue 1474483004: WebView Metrics client implementation (Chromium part) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from #10 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/DEPS » ('j') | android_webview/browser/aw_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index b5f5fbcf9c8aad3caccf3a7e6600b9653eaeed99..fe740800894a7656c934668e7494071c4bb39dc1 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -350,6 +350,8 @@ source_set("common") {
"browser/aw_message_port_message_filter.cc",
"browser/aw_message_port_message_filter.h",
"browser/aw_message_port_service.h",
+ "browser/aw_metrics_service_client.cc",
+ "browser/aw_metrics_service_client.h",
"browser/aw_permission_manager.cc",
"browser/aw_permission_manager.h",
"browser/aw_pref_store.cc",
@@ -479,6 +481,9 @@ source_set("common") {
"//components/crash/content/browser",
"//components/data_reduction_proxy/core/browser",
"//components/devtools_discovery",
+ "//components/metrics",
+ "//components/metrics:net",
+ "//components/metrics:ui",
"//components/navigation_interception",
"//components/printing/browser",
"//components/printing/common",
@@ -560,6 +565,7 @@ android_library("android_webview_java") {
"java/src/org/chromium/android_webview/AwLayoutSizer.java",
"java/src/org/chromium/android_webview/AwMessagePort.java",
"java/src/org/chromium/android_webview/AwMessagePortService.java",
+ "java/src/org/chromium/android_webview/AwMetricsServiceClient.java",
"java/src/org/chromium/android_webview/AwPdfExporter.java",
"java/src/org/chromium/android_webview/AwPicture.java",
"java/src/org/chromium/android_webview/AwPrintDocumentAdapter.java",
@@ -588,6 +594,7 @@ android_library("android_webview_java") {
"java/src/org/chromium/android_webview/OverScrollGlow.java",
"java/src/org/chromium/android_webview/permission/AwGeolocationCallback.java",
"java/src/org/chromium/android_webview/permission/AwPermissionRequest.java",
+ "java/src/org/chromium/android_webview/PlatformServiceBridge.java",
sgurun-gerrit only 2015/12/23 00:08:56 nit: the file seems to have some violations on the
paulmiller 2016/01/04 22:41:11 obviated by rebase. This section of the file was r
"java/src/org/chromium/android_webview/policy/AwPolicyProvider.java",
"java/src/org/chromium/android_webview/PostMessageSender.java",
"java/src/org/chromium/android_webview/ScrollAccessibilityHelper.java",
« no previous file with comments | « no previous file | android_webview/DEPS » ('j') | android_webview/browser/aw_metrics_service_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698