Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1474473003: Add a collapsible toggle button to the MD "Passwords and Forms" section. (Closed)

Created:
5 years ago by hcarmona
Modified:
5 years ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@password-show-list.gitbr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a collapsible toggle button to the MD "Passwords and Forms" section. The toggle buttons are enabled/disabled based on the appropriate setting. The buttons currently toggle properties that will control the collapsible sections. The collapsible sections will be added in follow-up CLs. BUG=546836 Committed: https://crrev.com/26e8d653923a0981aa6c4f41a770a61c5398eb9a Cr-Commit-Position: refs/heads/master@{#361399}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js View 1 1 chunk +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
hcarmona
Is it ok to use the prefs like this or should there be a pref ...
5 years ago (2015-11-24 03:04:34 UTC) #2
dschuyler
https://codereview.chromium.org/1474473003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js File chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js (right): https://codereview.chromium.org/1474473003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js#newcode18 chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:18: properties: { Let's add prefs: { ... } here. ...
5 years ago (2015-11-24 03:19:35 UTC) #3
hcarmona
https://codereview.chromium.org/1474473003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js File chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js (right): https://codereview.chromium.org/1474473003/diff/1/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js#newcode18 chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:18: properties: { On 2015/11/24 03:19:35, dschuyler wrote: > Let's ...
5 years ago (2015-11-24 03:34:31 UTC) #4
dschuyler
lgtm
5 years ago (2015-11-24 03:46:27 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1457713007 Patch 20001). Please resolve the dependency and ...
5 years ago (2015-11-24 18:24:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474473003/20001
5 years ago (2015-11-24 18:33:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 18:42:24 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 18:43:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26e8d653923a0981aa6c4f41a770a61c5398eb9a
Cr-Commit-Position: refs/heads/master@{#361399}

Powered by Google App Engine
This is Rietveld 408576698