Update the "Passwords and Forms" section so that they can be toggled.

Update the "Passwords and Forms" section so that they can be toggled.

This CL enabled toggling both the "Autofill settings" and "Manage
passwords" sections under "Passwords and Forms".

BUG=546836
Committed: https://crrev.com/a38a8684b76424bc801cfb6e0a1b4d5a5097e978
Cr-Commit-Position: refs/heads/master@{#361392}

[hcarmona, 2015-11-20 03:21:00]

hcarmona@chromium.org changed reviewers:
+ dschuyler@chromium.org

[hcarmona, 2015-11-20 03:21:00]

Hey Dave,

This is missing the part where the setting is populated, but currently does
update the setting. (write only for now essentially)

Can you take a quick look at this to make sure I'm going down the right path?

Thanks!

[dschuyler, 2015-11-20 20:02:50]

Let's look at whether prefs_util can handle this pref setting without using a
custom chrome.send handler.

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_category.js
(right):

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_category.js:6:
* @fileoverview 'settings-passwords-and-forms-page' is the settings page
This looks like it is referring to a type: 'settings-passwords-and-forms-page'
Should it be this instead? 'autofill-category'

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_category.js:20:
* Preferences state.
Add @type for the Object.
For simple properties like String and Boolean the @type is not needed.
But for Object and Array, add an @type (or @private).

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_category.js:58:
chrome.send(this.prefUpdate, [this.checked]);
Does this need to be an array: [this.checked]?

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
(right):

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:10:
i18n-values="title:autofill;detail:autofillDetail">
Is this going to get a pref-update in a later CL?

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/passwords_handler.cc (right):

https://codereview.chromium.org/1457713007/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/passwords_handler.cc:32:
prefs->SetBoolean(password_manager::prefs::kPasswordManagerSavingEnabled,
Can this be exposed with settingsPrivate rather
than a chrome.send handler?

[hcarmona, 2015-11-24 01:23:19]

Description was changed from

==========
Update the MD settings "Passwords" section to allow toggling.

BUG=546836
==========

to

==========
Update the "Passwords and Forms" section so that they can be toggled.

This CL enabled toggling both the "Autofill settings" and "Manage
passwords" sections under "Passwords and Forms".

BUG=546836
==========

[hcarmona, 2015-11-24 01:24:43]

Thanks for the great feedback! Using the prefs_util addresses my issues
and simplifies the code. I've updated the description to match my
updated changes. PTAL.

[dschuyler, 2015-11-24 01:47:23]

lgtm

[hcarmona, 2015-11-24 01:51:13]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457713007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457713007/20001

[commit-bot: I haz the power, 2015-11-24 03:22:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:22:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hcarmona, 2015-11-24 03:33:24]

hcarmona@chromium.org changed reviewers:
+ stevenjb@chromium.org

[hcarmona, 2015-11-24 03:33:25]

stevenjb@, PTAL at prefs_util.cc

This makes both sections toggle-able for passwords and forms.

Thanks!

[stevenjb, 2015-11-24 17:56:50]

lgtm

[hcarmona, 2015-11-24 18:21:52]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-11-24 18:22:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457713007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457713007/20001

[commit-bot: I haz the power, 2015-11-24 18:29:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 18:31:03]

Patchset 2 (id:??) landed as
https://crrev.com/a38a8684b76424bc801cfb6e0a1b4d5a5097e978
Cr-Commit-Position: refs/heads/master@{#361392}