Remove easy to remove calls to Isolate::Current() from api.cc

Remove easy to remove calls to Isolate::Current() from api.cc

R=vogelheim@chromium.org
LOG=n
BUG=v8:2487
Committed: https://crrev.com/7730edcc1226c03a577ea699d2fb29fb11fccf60
Cr-Commit-Position: refs/heads/master@{#32389}

[vogelheim, 2015-11-27 16:06:15]

lgtm

https://codereview.chromium.org/1474353002/diff/1/src/profiler/heap-snapshot-...
File src/profiler/heap-snapshot-generator.h (right):

https://codereview.chromium.org/1474353002/diff/1/src/profiler/heap-snapshot-...
src/profiler/heap-snapshot-generator.h:52: INLINE(HeapSnapshot* snapshot()
const);
Not sure if worthwhile, but I think you're exposing this only to get to an
Isolate*. If so, you could also leave snapshot() private, and add
  isolate() { return snapshot()->profiler()->isolate(); }

https://codereview.chromium.org/1474353002/diff/1/src/profiler/profile-genera...
File src/profiler/profile-generator.h (right):

https://codereview.chromium.org/1474353002/diff/1/src/profiler/profile-genera...
src/profiler/profile-generator.h:159: ProfileTree* tree() const { return tree_;
}
... or isolate(); similar to previous comment.

[jochen (gone - plz use gerrit), 2015-11-30 07:56:49]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-30 07:56:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1474353002/#ps20001
(title: "update")

[jochen (gone - plz use gerrit), 2015-11-30 07:57:00]

done

[commit-bot: I haz the power, 2015-11-30 07:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474353002/20001

[commit-bot: I haz the power, 2015-11-30 08:16:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-30 08:17:06]

Description was changed from

==========
Remove easy to remove calls to Isolate::Current() from api.cc

R=vogelheim@chromium.org
LOG=n
BUG=v8:2487
==========

to

==========
Remove easy to remove calls to Isolate::Current() from api.cc

R=vogelheim@chromium.org
LOG=n
BUG=v8:2487

Committed: https://crrev.com/7730edcc1226c03a577ea699d2fb29fb11fccf60
Cr-Commit-Position: refs/heads/master@{#32389}
==========

[commit-bot: I haz the power, 2015-11-30 08:17:07]

Patchset 2 (id:??) landed as
https://crrev.com/7730edcc1226c03a577ea699d2fb29fb11fccf60
Cr-Commit-Position: refs/heads/master@{#32389}

[ulan, 2016-03-04 16:01:01]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-03-04 16:01:02]

https://codereview.chromium.org/1474353002/diff/20001/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/1474353002/diff/20001/include/v8.h#oldcode4780
include/v8.h:4780: static Local<TypeSwitch> New(Local<FunctionTemplate> type);
This was removed without any deprecation notice. What should users use instead
of it?

[jochen (gone - plz use gerrit), 2016-03-04 16:08:42]

https://codereview.chromium.org/1474353002/diff/20001/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/1474353002/diff/20001/include/v8.h#oldcode4780
include/v8.h:4780: static Local<TypeSwitch> New(Local<FunctionTemplate> type);
On 2016/03/04 at 16:01:02, ulan wrote:
> This was removed without any deprecation notice. What should users use instead
of it?

I did a search and didn't find any users of it. I hope I didn't miss one?