Remove easy to remove calls to Isolate::Current() from api.cc

src/profiler/heap-snapshot-generator.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PROFILER_HEAP_SNAPSHOT_GENERATOR_H_
 #define V8_PROFILER_HEAP_SNAPSHOT_GENERATOR_H_
 
 #include "include/v8-profiler.h"
 #include "src/base/platform/time.h"
 #include "src/objects.h"
@@ skipping 31 matching lines @@
     DCHECK(type() == kElement || type() == kHidden);
     return index_;
   }
   const char* name() const {
     DCHECK(type() == kContextVariable || type() == kProperty ||
            type() == kInternal || type() == kShortcut || type() == kWeak);
     return name_;
   }
   INLINE(HeapEntry* from() const);
   HeapEntry* to() const { return to_entry_; }
+  INLINE(HeapSnapshot* snapshot() const);

[vogelheim, 2015/11/27 16:06:15]

Not sure if worthwhile, but I think you're exposing this only to get to an
Isolate*. If so, you could also leave snapshot() private, and add
  isolate() { return snapshot()->profiler()->isolate(); }

 
  private:
-  INLINE(HeapSnapshot* snapshot() const);
   int from_index() const { return FromIndexField::decode(bit_field_); }
 
   class TypeField : public BitField<Type, 0, 3> {};
   class FromIndexField : public BitField<int, 3, 29> {};
   uint32_t bit_field_;
   union {
     // During entries population |to_index_| is used for storing the index,
     // afterwards it is replaced with a pointer to the entry.
     int to_index_;
     HeapEntry* to_entry_;
@@ skipping 552 matching lines @@
   friend class HeapSnapshotJSONSerializerIterator;
 
   DISALLOW_COPY_AND_ASSIGN(HeapSnapshotJSONSerializer);
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PROFILER_HEAP_SNAPSHOT_GENERATOR_H_