Do not use bundles for the CDM on Mac.

Do not use bundles for the CDM on Mac.

When using components, the CDM and adapter cannot be within the Chrome bundle.
Since the adapter is built with Chrome, the CDM cannot be within its bundle.
As a result, the adapter no longer needs to be a bundle.

The chrome_paths.cc code allows testing with the non-component path.

BUG=180260
R=xhwang@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198211

[xhwang, 2013-05-02 19:39:17]

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
File chrome/common/chrome_paths.cc (right):

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:358: // TODO(xhwang): DIR_WIDEVINE_CDM is used for
Win/Mac/Linux and
Can you help me drop "/Linux" in this line? Thanks

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:376: // DIR_MODULE gave us .../
what's .../ ?

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:382: cur = cur.DirName();
why call this 5 times?

https://codereview.chromium.org/14743002/diff/15001/webkit/media/webkit_media...
File webkit/media/webkit_media.gypi (right):

https://codereview.chromium.org/14743002/diff/15001/webkit/media/webkit_media...
webkit/media/webkit_media.gypi:244: 'DYLIB_INSTALL_NAME_BASE': '@loader_path',
does our content_browsertests still work with this change?

[ddorwin, 2013-05-02 20:35:56]

brettw, please do an OWNERS review of chrome_paths.cc to support Mac.

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
File chrome/common/chrome_paths.cc (right):

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:358: // TODO(xhwang): DIR_WIDEVINE_CDM is used for
Win/Mac/Linux and
On 2013/05/02 19:39:17, xhwang wrote:
> Can you help me drop "/Linux" in this line? Thanks

Done.

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:376: // DIR_MODULE gave us .../
On 2013/05/02 19:39:17, xhwang wrote:
> what's .../ ?

Done.

https://codereview.chromium.org/14743002/diff/15001/chrome/common/chrome_path...
chrome/common/chrome_paths.cc:382: cur = cur.DirName();
On 2013/05/02 19:39:17, xhwang wrote:
> why call this 5 times?

Each one returns the parent directory I guess. The result is the equivalent of
evaluating "../". I copied this from the pnacl code in this file.

https://codereview.chromium.org/14743002/diff/15001/webkit/media/webkit_media...
File webkit/media/webkit_media.gypi (right):

https://codereview.chromium.org/14743002/diff/15001/webkit/media/webkit_media...
webkit/media/webkit_media.gypi:244: 'DYLIB_INSTALL_NAME_BASE': '@loader_path',
On 2013/05/02 19:39:17, xhwang wrote:
> does our content_browsertests still work with this change?

Works on my box. Trybots are running.
I think it's fine - since the two dylibs (no bundles) are side-by-side,
everything works fine. If this was still a bundle, we'd have to fix the CDM's
loader_path to account for the real binary in the bundle being 3 levels deep.

[xhwang, 2013-05-02 20:50:04]

lgtm

[ddorwin, 2013-05-03 00:54:29]

Removed the path change since the same enum is used by components and does not
work with this change.

[commit-bot: I haz the power, 2013-05-03 01:26:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/14743002/33001

[commit-bot: I haz the power, 2013-05-03 02:14:43]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 02:15:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/14743002/33001

[commit-bot: I haz the power, 2013-05-03 03:05:19]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 04:36:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/14743002/33001

[commit-bot: I haz the power, 2013-05-03 05:19:35]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 06:12:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/14743002/33001

[commit-bot: I haz the power, 2013-05-03 06:56:33]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 16:35:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ddorwin@chromium.org/14743002/33001

[commit-bot: I haz the power, 2013-05-03 17:28:47]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[ddorwin, 2013-05-03 22:12:35]

Committed patchset #9 manually as r198211 (presubmit successful).