Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: build/landmines.py

Issue 14743002: Do not use bundles for the CDM on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do not bundle adapter yet Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | third_party/widevine/cdm/widevine_cdm.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file holds a list of reasons why a particular build needs to be clobbered 7 This file holds a list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 9
10 This script runs every build as a hook. If it detects that the build should 10 This script runs every build as a hook. If it detects that the build should
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 if (distributor() == 'goma' and platform() == 'win32' and 141 if (distributor() == 'goma' and platform() == 'win32' and
142 builder() == 'ninja'): 142 builder() == 'ninja'):
143 add('Need to clobber winja goma due to backend cwd cache fix.') 143 add('Need to clobber winja goma due to backend cwd cache fix.')
144 if platform() == 'android': 144 if platform() == 'android':
145 add('Clobber: Resources removed in r195014 require clobber.') 145 add('Clobber: Resources removed in r195014 require clobber.')
146 if platform() == 'win' and builder() == 'ninja': 146 if platform() == 'win' and builder() == 'ninja':
147 add('Compile on cc_unittests fails due to symbols removed in r185063.') 147 add('Compile on cc_unittests fails due to symbols removed in r185063.')
148 if platform() == 'linux' and builder() == 'ninja': 148 if platform() == 'linux' and builder() == 'ninja':
149 add('Builders switching from make to ninja will clobber on this.') 149 add('Builders switching from make to ninja will clobber on this.')
150 if platform() == 'mac':
151 add('Switching from bundle to unbundled dylib (issue 14743002).')
150 152
151 return landmines 153 return landmines
152 154
153 155
154 def get_target_build_dir(build_tool, target, is_iphone=False): 156 def get_target_build_dir(build_tool, target, is_iphone=False):
155 """ 157 """
156 Returns output directory absolute path dependent on build and targets. 158 Returns output directory absolute path dependent on build and targets.
157 Examples: 159 Examples:
158 r'c:\b\build\slave\win\build\src\out\Release' 160 r'c:\b\build\slave\win\build\src\out\Release'
159 '/mnt/data/b/build/slave/linux/build/src/out/Debug' 161 '/mnt/data/b/build/slave/linux/build/src/out/Debug'
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 gyp_helper.apply_chromium_gyp_env() 228 gyp_helper.apply_chromium_gyp_env()
227 229
228 for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'): 230 for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'):
229 set_up_landmines(target) 231 set_up_landmines(target)
230 232
231 return 0 233 return 0
232 234
233 235
234 if __name__ == '__main__': 236 if __name__ == '__main__':
235 sys.exit(main()) 237 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | third_party/widevine/cdm/widevine_cdm.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698