Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 1474253002: Remove CSSPrimitiveValue::isDotsPer{Inch,Pixel,Centimeter} functions (Closed)

Created:
5 years ago by Timothy Loh
Modified:
5 years ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, kenneth.christiansen, rwlbuis, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CSSPrimitiveValue::isDotsPer{Inch,Pixel,Centimeter} functions The functions CSSPrimitiveValue::isDotsPer{Inch,Pixel,Centimeter} don't seem to add any value, and only one is used. This patch removes them and inlines the dpcm code into the one caller Committed: https://crrev.com/729ec5cb8531f23032a707c101a0b9fab63d4010 Cr-Commit-Position: refs/heads/master@{#361951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
5 years ago (2015-11-27 03:52:34 UTC) #2
dstockwell
lgtm
5 years ago (2015-11-27 04:08:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474253002/1
5 years ago (2015-11-27 04:08:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 04:53:28 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-27 04:54:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/729ec5cb8531f23032a707c101a0b9fab63d4010
Cr-Commit-Position: refs/heads/master@{#361951}

Powered by Google App Engine
This is Rietveld 408576698