Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1474233002: Don't set internal paddings for menulist SELECT with -webkit-appearance:none. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set internal paddings for menulist SELECT with -webkit-appearance:none. BUG=554951 Committed: https://crrev.com/62e05f985c96da53fb91a25307950bc17ba875e1 Cr-Commit-Position: refs/heads/master@{#361950}

Patch Set 1 : #

Messages

Total messages: 9 (4 generated)
tkent
Keishi, would you review this please?
5 years ago (2015-11-27 04:09:17 UTC) #3
keishi
LGTM
5 years ago (2015-11-27 04:20:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474233002/20001
5 years ago (2015-11-27 04:36:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-11-27 04:41:04 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-27 04:41:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e05f985c96da53fb91a25307950bc17ba875e1
Cr-Commit-Position: refs/heads/master@{#361950}

Powered by Google App Engine
This is Rietveld 408576698