[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}

Committed: https://crrev.com/2fee8a0f1d3dca6fe955077c5a41020948a7a0f1
Cr-Commit-Position: refs/heads/master@{#32386}

[Jakob Kummerow, 2015-11-27 08:40:59]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2015-11-27 08:40:59]

Toon: PTAL.

Georg, Camillo: FYI.

[Benedikt Meurer, 2015-11-27 12:56:45]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-11-27 12:56:46]

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc#newcode8305
src/objects.cc:8305: std::unordered_set<Object*> unchecked_result_keys;
We're not allowed to use C++11 library features yet, so std::unordered_set is a
no-go for now.
Also I'd prefer something more robust, without DisallowHeapAllocation black
magic.
How about using IdentityMap or something like that?

[Toon Verwaest, 2015-11-27 12:57:43]

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc#newcode8278
src/objects.cc:8278: bool found = JSReceiver::GetOwnPropertyDescriptor(
This should probably be Maybe<bool>. Fine to change in follow-up.

[Jakob Kummerow, 2015-11-27 16:01:41]

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc#newcode8278
src/objects.cc:8278: bool found = JSReceiver::GetOwnPropertyDescriptor(
On 2015/11/27 12:57:43, Toon Verwaest wrote:
> This should probably be Maybe<bool>. Fine to change in follow-up.

Acknowledged. Will do a follow-up.

https://codereview.chromium.org/1474083003/diff/1/src/objects.cc#newcode8305
src/objects.cc:8305: std::unordered_set<Object*> unchecked_result_keys;
On 2015/11/27 12:56:46, Benedikt Meurer wrote:
> We're not allowed to use C++11 library features yet, so std::unordered_set is
a
> no-go for now.

Bummer.

> Also I'd prefer something more robust, without DisallowHeapAllocation black
> magic.

DisallowHeapAllocation is not black magic, it's just a kind of DCHECK. I
disagree that we should invest extra effort to make things GC safe that don't
need to be. That said...

> How about using IdentityMap or something like that?

...done.

[Toon Verwaest, 2015-11-28 08:44:53]

lgtm

[Toon Verwaest, 2015-11-28 08:44:57]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-11-28 08:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474083003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474083003/20001

[commit-bot: I haz the power, 2015-11-28 08:50:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-28 08:50:38]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/24)

[Jakob Kummerow, 2015-11-28 10:24:03]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-11-28 10:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1474083003/#ps40001
(title: "windows ♥")

[commit-bot: I haz the power, 2015-11-28 10:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474083003/40001

[commit-bot: I haz the power, 2015-11-28 10:48:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-28 10:48:49]

Description was changed from

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

[commit-bot: I haz the power, 2015-11-28 10:48:50]

Patchset 3 (id:??) landed as
https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}

[Michael Achenbach, 2015-11-28 14:15:53]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1482113002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for gc mole:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/build....

[Jakob Kummerow, 2015-11-28 14:44:04]

Description was changed from

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

to

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

[Jakob Kummerow, 2015-11-28 14:44:16]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2015-11-28 14:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1474083003/#ps60001
(title: "gcmole fix")

[commit-bot: I haz the power, 2015-11-28 14:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474083003/60001

[commit-bot: I haz the power, 2015-11-28 15:03:05]

Description was changed from

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

to

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

[commit-bot: I haz the power, 2015-11-28 15:03:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-28 15:03:24]

Description was changed from

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}
==========

to

==========
[proxies] Implement [[Enumerate]] and [[OwnPropertyKeys]]

Both are integrated into JSReceiver::GetKeys().

For now, the implementation ignores Symbol/DONT_ENUM filtering.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/42c6056e6f247724d14dc887f6619a6bf5867a97
Cr-Commit-Position: refs/heads/master@{#32384}

Committed: https://crrev.com/2fee8a0f1d3dca6fe955077c5a41020948a7a0f1
Cr-Commit-Position: refs/heads/master@{#32386}
==========

[commit-bot: I haz the power, 2015-11-28 15:03:25]

Patchset 4 (id:??) landed as
https://crrev.com/2fee8a0f1d3dca6fe955077c5a41020948a7a0f1
Cr-Commit-Position: refs/heads/master@{#32386}