Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1474083002: Add a use counter for Attr.prototype.cloneNode() (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken, Ilya Sherman
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter for Attr.prototype.cloneNode() This is being measured as requested in a spec discussion: https://github.com/whatwg/dom/issues/102#issuecomment-158833267 To avoid making a observable change to Attr.prototype, measure this internally. This risks including internal uses, but there appear to be none. All calls were checked and they seem to be for either parent or child nodes of some kind, and Attr cannot be a parent or child. Also, a deprecation message was added to see if it would be triggered unexpectedly on any tests, but it was only emitted for tests that actually clone attributes, as expected. Drive-by: Drop an unused ShadowRoot::cloneNode() that was missed in https://codereview.chromium.org/1482433003 BUG=305105 Committed: https://crrev.com/fff1c216222319d3f6030744810e236df195fb1a Cr-Commit-Position: refs/heads/master@{#361932}

Patch Set 1 #

Patch Set 2 : drop deprecation test message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Attr.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
philipj_slow
PTAL. I know this will conflict so I haven't started the bots, see PS1 for ...
5 years ago (2015-11-26 14:20:31 UTC) #4
haraken
LGTM
5 years ago (2015-11-26 15:12:18 UTC) #5
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-11-26 20:52:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474083002/20001
5 years ago (2015-11-26 21:46:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 23:33:52 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 23:34:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fff1c216222319d3f6030744810e236df195fb1a
Cr-Commit-Position: refs/heads/master@{#361932}

Powered by Google App Engine
This is Rietveld 408576698