Source/core/accessibility/AccessibilityListBoxOption.cpp - Issue 14740025: Simplify and add caching for accessible bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityListBoxOption.cpp

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing with null check fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityListBoxOption.cpp

diff --git a/Source/core/accessibility/AccessibilityListBoxOption.cpp b/Source/core/accessibility/AccessibilityListBoxOption.cpp

index dd3dbe98f9fb67857c66605887c8521da3b740a6..4956237ee3a091f8fd49330923a58c2f1f0ed0a6 100644

--- a/Source/core/accessibility/AccessibilityListBoxOption.cpp

+++ b/Source/core/accessibility/AccessibilityListBoxOption.cpp

@@ -106,7 +106,7 @@ LayoutRect AccessibilityListBoxOption::elementRect() const

if (!listBoxRenderer)

return rect;

- LayoutRect parentRect = listBoxRenderer->document()->axObjectCache()->getOrCreate(listBoxRenderer)->boundingBoxRect();

+ LayoutRect parentRect = listBoxRenderer->document()->axObjectCache()->getOrCreate(listBoxRenderer)->elementRect();

int index = listBoxOptionIndex();

if (index != -1)

rect = toRenderListBox(listBoxRenderer)->itemBoundingBoxRect(parentRect.location(), index);