Source/core/accessibility/AccessibilityListBox.cpp - Issue 14740025: Simplify and add caching for accessible bounding box calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AccessibilityListBox.cpp

Issue 14740025: Simplify and add caching for accessible bounding box calculation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Re-landing with null check fix Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/accessibility/AccessibilityListBox.cpp

diff --git a/Source/core/accessibility/AccessibilityListBox.cpp b/Source/core/accessibility/AccessibilityListBox.cpp

index 718a27eba0e2c8878790b3cf0c3968ab5b8e78ae..0adad7bd03bf1884836dd55e10f15da7c8426c08 100644

--- a/Source/core/accessibility/AccessibilityListBox.cpp

+++ b/Source/core/accessibility/AccessibilityListBox.cpp

@@ -160,7 +160,7 @@ AccessibilityObject* AccessibilityListBox::elementAccessibilityHitTest(const Int

if (!node)

return 0;

- LayoutRect parentRect = boundingBoxRect();

+ LayoutRect parentRect = elementRect();

AccessibilityObject* listBoxOption = 0;

unsigned length = m_children.size();