Issue 1473943002: Merge to XFA: CFXJS_ObjDefinition's lifetime must match isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1473943002: Merge to XFA: CFXJS_ObjDefinition's lifetime must match isolate. (Closed)

Created:
5 years ago by Tom Sepez

Modified:
5 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: CFXJS_ObjDefinition's lifetime must match isolate. Review URL: https://codereview.chromium.org/1468423004 . (cherry picked from commit 628f7053cc646c58c61add247c75bc65ac135327) BUG=561184 TBR=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8b90ee66872aa883fc46ac2b6e7acad35c7c96c6

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Tom Sepez

5 years ago (2015-11-25 18:38:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b90ee66872aa883fc46ac2b6e7acad35c7c96c6 (presubmit successful).