Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 1468423004: CFXJS_ObjDefinition's lifetime must match isolate. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

CFXJS_ObjDefinition's lifetime must match isolate. Introduced at https://codereview.chromium.org/1424933013/ The v8 objects are 1:1 with the context being destroyed in FXJS_ReleaseRuntime, but the CFXJS_ObjDefinitions are still 1:1 with the isolate, so they can't be destroyed until the refcounts hit zero. BUG=561184 R=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/628f7053cc646c58c61add247c75bc65ac135327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-11-25 18:27:47 UTC) #2
Tom Sepez
Jochen, please review.
5 years, 2 months ago (2015-11-25 18:28:37 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-11-25 18:30:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
628f7053cc646c58c61add247c75bc65ac135327 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698