Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Issue 1473783003: Clarify how to replace ForceSet (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clarify how to replace ForceSet BUG=none R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/5335e7d55a99f931f4de3b0c4b6ba52291030c2c Cr-Commit-Position: refs/heads/master@{#32263}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/v8.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 10:02:46 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/1473783003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1473783003/diff/1/include/v8.h#newcode2923 include/v8.h:2923: V8_DEPRECATE_SOON("Use v8::Object::GetHidden instead.", GetHidden -> GetPrivate [Sorry for ...
5 years ago (2015-11-25 10:06:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473783003/20001
5 years ago (2015-11-25 10:10:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 11:17:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 11:18:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5335e7d55a99f931f4de3b0c4b6ba52291030c2c
Cr-Commit-Position: refs/heads/master@{#32263}

Powered by Google App Engine
This is Rietveld 408576698