Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: include/v8.h

Issue 1473783003: Clarify how to replace ForceSet (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 276e0721eba2bca957d6e31043d730f1558b7f62..6ecbcd7d39e6e6b48ad471b94d1fcbf36d6d3d45 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2662,10 +2662,10 @@ class V8_EXPORT Object : public Value {
// will only be returned if the interceptor doesn't return a value.
//
// Note also that this only works for named properties.
- V8_DEPRECATE_SOON("Use CreateDataProperty",
+ V8_DEPRECATE_SOON("Use CreateDataProperty / DefineOwnProperty",
bool ForceSet(Local<Value> key, Local<Value> value,
PropertyAttribute attribs = None));
- V8_DEPRECATE_SOON("Use CreateDataProperty",
+ V8_DEPRECATE_SOON("Use CreateDataProperty / DefineOwnProperty",
Maybe<bool> ForceSet(Local<Context> context,
Local<Value> key, Local<Value> value,
PropertyAttribute attribs = None));
@@ -2920,7 +2920,7 @@ class V8_EXPORT Object : public Value {
V8_DEPRECATE_SOON("Use v8::Object::SetPrivate instead.",
bool SetHiddenValue(Local<String> key, Local<Value> value));
- V8_DEPRECATE_SOON("Use v8::Object::GetHidden instead.",
+ V8_DEPRECATE_SOON("Use v8::Object::GetPrivate instead.",
Local<Value> GetHiddenValue(Local<String> key));
V8_DEPRECATE_SOON("Use v8::Object::DeletePrivate instead.",
bool DeleteHiddenValue(Local<String> key));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698