Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1473683004: Lazily initialize fast_sqrt() and pass an Isolate parameter to it (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Lazily initialize fast_sqrt() and pass an Isolate parameter to it R=jkummerow@chromium.org BUG=v8:2487 LOG=n Committed: https://crrev.com/27001ca6527c03292b889b9a32f938d1d0b89d8e Cr-Commit-Position: refs/heads/master@{#32287}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -105 lines) Patch
M src/arm/codegen-arm.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/codegen.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/codegen.cc View 1 chunk +15 lines, -34 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/mips/simulator-mips.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/x87/codegen-x87.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-25 15:04:38 UTC) #1
Jakob Kummerow
LGTM with two nits: one is below, the other is that the BUG= line should ...
5 years ago (2015-11-25 15:23:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473683004/20001
5 years ago (2015-11-25 15:25:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 16:37:17 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-25 16:37:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27001ca6527c03292b889b9a32f938d1d0b89d8e
Cr-Commit-Position: refs/heads/master@{#32287}

Powered by Google App Engine
This is Rietveld 408576698