Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1473613002: Revert of Add test to check PRNG quality. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add test to check PRNG quality. (patchset #3 id:40001 of https://codereview.chromium.org/1467133006/ ) Reason for revert: [Sheriff] Times out on arm: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/6202/steps/Check/logs/RandomBitCorrelations Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} TBR=jkummerow@chromium.org,erikcorry@google.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Committed: https://crrev.com/29f4515d61da407250d443a17f869d2f6c7a7cfe Cr-Commit-Position: refs/heads/master@{#32215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -101 lines) Patch
M test/cctest/test-random-number-generator.cc View 1 chunk +0 lines, -101 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Add test to check PRNG quality.
5 years ago (2015-11-24 14:49:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473613002/1
5 years ago (2015-11-24 14:49:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 14:49:30 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 14:50:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29f4515d61da407250d443a17f869d2f6c7a7cfe
Cr-Commit-Position: refs/heads/master@{#32215}

Powered by Google App Engine
This is Rietveld 408576698