Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7744)

Unified Diff: chrome/browser/ui/webui/sync_setup_browsertest.js

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_setup_browsertest.js
diff --git a/chrome/browser/ui/webui/sync_setup_browsertest.js b/chrome/browser/ui/webui/sync_setup_browsertest.js
index e65c4026e26595716324876aa4242f40b592fdde..528c2fec681f162e6d8c229e409e4fa90f939f7a 100644
--- a/chrome/browser/ui/webui/sync_setup_browsertest.js
+++ b/chrome/browser/ui/webui/sync_setup_browsertest.js
@@ -85,8 +85,8 @@ TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {
// Handle SyncSetupStartSignIn by displaying the sync setup dialog, verifying
// that a confirmation dialog appears, and clicking OK to dismiss the dialog.
// Note that this test doesn't actually do a gaia sign in.
- this.mockHandler.expects(once()).SyncSetupStartSignIn().will(callFunction(
- function() {
+ this.mockHandler.expects(once()).SyncSetupStartSignIn(
+ 'access-point-settings').will(callFunction(function() {
SyncSetupOverlay.showSyncSetupPage('configure');
var okButton = $('confirm-everything-ok');
assertNotEquals(null, okButton);
@@ -103,8 +103,8 @@ TEST_F('SyncSetupWebUITestAsync', 'VerifySignIn', function() {
// Test that switching to and from "Sync everything" saves and restores types.
TEST_F('SyncSetupWebUITestAsync', 'RestoreSyncDataTypes', function() {
- this.mockHandler.expects(once()).SyncSetupStartSignIn().will(callFunction(
- function() {
+ this.mockHandler.expects(once()).SyncSetupStartSignIn(
+ 'access-point-settings').will(callFunction(function() {
SyncSetupOverlay.showSyncSetupPage('configure', {});
$('sync-select-datatypes').selectedIndex = 1;
« no previous file with comments | « chrome/browser/ui/webui/signin/login_ui_test_utils.cc ('k') | chrome/browser/ui/webui/webui_webview_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698