Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9373)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_test_utils.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/login_ui_test_utils.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
index c1548376074e28f15e0b0a4287ca5190e264a4df..44dcc6b6cbc4939ba9e38f68f75a1b416b1bc67c 100644
--- a/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
@@ -206,13 +206,15 @@ bool SignInWithUI(Browser* browser,
const std::string& username,
const std::string& password,
bool wait_for_account_cookies,
- signin_metrics::Source signin_source) {
+ signin_metrics::AccessPoint access_point) {
SignInObserver signin_observer(wait_for_account_cookies);
scoped_ptr<SigninTracker> tracker =
SigninTrackerFactory::CreateForProfile(browser->profile(),
&signin_observer);
- GURL signin_url = signin::GetPromoURL(signin_source, false);
+ GURL signin_url = signin::GetPromoURL(
+ access_point, signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT,
+ false);
DVLOG(1) << "Navigating to " << signin_url;
// For some tests, the window is not shown yet and this might be the first tab
// navigation, so GetActiveWebContents() for CURRENT_TAB is NULL. That's why
@@ -236,8 +238,8 @@ bool SignInWithUI(Browser* browser,
const std::string& username,
const std::string& password) {
return SignInWithUI(browser, username, password,
- false /* wait_for_account_cookies */,
- signin_metrics::SOURCE_START_PAGE);
+ false /* wait_for_account_cookies */,
+ signin_metrics::AccessPoint::ACCESS_POINT_START_PAGE);
}
} // namespace login_ui_test_utils
« no previous file with comments | « chrome/browser/ui/webui/signin/login_ui_test_utils.h ('k') | chrome/browser/ui/webui/sync_setup_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698