chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/profiles/signin_view_controller.cc ('k') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc

diff --git a/chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc b/chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc

index ce4e839c24551d8c7a8aaf0b85389d37473944d3..8498e62b7eacc14aff8a5e4499cc1ec8b59b1eac 100644

--- a/chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc

+++ b/chrome/browser/ui/views/profiles/supervised_user_avatar_label.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/grit/generated_resources.h"

#include "components/signin/core/browser/signin_header_helper.h"

+#include "components/signin/core/browser/signin_metrics.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/theme_provider.h"

@@ -109,8 +110,8 @@ bool SupervisedUserAvatarLabel::OnMousePressed(const ui::MouseEvent& event) {

return false;

browser_view_->ShowAvatarBubbleFromAvatarButton(

- BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT,

- signin::ManageAccountsParams());

+ BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT, signin::ManageAccountsParams(),

+ signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

return true;

}