Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/signin_view_controller.cc
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller.cc b/chrome/browser/ui/views/profiles/signin_view_controller.cc
index d5fd524c046bb92c98711587bfdaa4e0d65474a5..18e9b5cbf116cbcd484adcb58452b5a2dac07d4b 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller.cc
+++ b/chrome/browser/ui/views/profiles/signin_view_controller.cc
@@ -97,8 +97,10 @@ SigninViewController::~SigninViewController() {
views::WebView* SigninViewController::CreateGaiaWebView(
content::WebContentsDelegate* delegate,
profiles::BubbleViewMode mode,
- Profile* profile) {
- GURL url = signin::GetSigninURLFromBubbleViewMode(profile, mode);
+ Profile* profile,
+ signin_metrics::AccessPoint access_point) {
+ GURL url =
+ signin::GetSigninURLFromBubbleViewMode(profile, mode, access_point);
// Adds Gaia signin webview.
const gfx::Size pref_size = switches::UsePasswordSeparatedSigninFlow()
@@ -121,12 +123,15 @@ views::WebView* SigninViewController::CreateGaiaWebView(
}
void SigninViewController::ShowModalSignin(
- profiles::BubbleViewMode mode, Browser* browser) {
+ profiles::BubbleViewMode mode,
+ Browser* browser,
+ signin_metrics::AccessPoint access_point) {
CloseModalSignin();
// The delegate will delete itself on request of the views code when the
// widget is closed.
modal_signin_delegate_ = new ModalSigninDelegate(
- this, CreateGaiaWebView(nullptr, mode, browser->profile()), browser);
+ this, CreateGaiaWebView(nullptr, mode, browser->profile(), access_point),
+ browser);
}
void SigninViewController::CloseModalSignin() {

Powered by Google App Engine
This is Rietveld 408576698