chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

index e1a0c3205d6547d23e46d53b5f7c1f74992a763b..ced33b0269fd92946119e9ef6b927747d5597c70 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

@@ -236,7 +236,8 @@ TEST_F(OneClickSigninSyncObserverTest,

TEST_F(OneClickSigninSyncObserverTest,

OnSyncStateChanged_SyncConfiguredSuccessfully_SourceIsSettings) {

GURL continue_url = signin::GetPromoURL(

- signin_metrics::SOURCE_SETTINGS, false);

+ signin_metrics::AccessPoint::ACCESS_POINT_SETTINGS,

+ signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT, false);

CreateSyncObserver(continue_url.spec());

sync_service_->set_first_setup_in_progress(false);

sync_service_->set_sync_active(true);

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_observer.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.h » ('j') | no next file with comments »