Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2416)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_observer.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
index 69069ddaef7403e8c6bb518af0123ba4c7f812e6..38ed198dbfcdb021ddf9327ea175dcc6c46c4081 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer.cc
@@ -79,8 +79,8 @@ void OneClickSigninSyncObserver::OnStateChanged() {
}
if (sync_service->IsSyncActive() &&
- signin::GetSourceForPromoURL(continue_url_)
- != signin_metrics::SOURCE_SETTINGS) {
+ signin::GetAccessPointForPromoURL(continue_url_) !=
+ signin_metrics::AccessPoint::ACCESS_POINT_SETTINGS) {
// TODO(isherman): Having multiple settings pages open can cause issues
// redirecting after Sync is set up: http://crbug.com/355885
LoadContinueUrl();

Powered by Google App Engine
This is Rietveld 408576698