chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index c1982e0ca15676ed4031b14d21b48c46fbc9e985..9a6071a63c188103a7a26d9b374d53f45cfae650 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -840,17 +840,21 @@ NSWindow* BrowserWindowCocoa::window() const {

void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

AvatarBubbleMode mode,

- const signin::ManageAccountsParams& manage_accounts_params) {

+ const signin::ManageAccountsParams& manage_accounts_params,

+ signin_metrics::AccessPoint access_point) {

AvatarBaseController* controller = [controller_ avatarButtonController];

NSView* anchor = [controller buttonView];

if ([anchor isHiddenOrHasHiddenAncestor])

anchor = [[controller_ toolbarController] wrenchButton];

[controller showAvatarBubbleAnchoredAt:anchor

withMode:mode

- withServiceType:manage_accounts_params.service_type];

+ withServiceType:manage_accounts_params.service_type

+ fromAccessPoint:access_point];

}

-void BrowserWindowCocoa::ShowModalSigninWindow(AvatarBubbleMode mode) {

+void BrowserWindowCocoa::ShowModalSigninWindow(

+ AvatarBubbleMode mode,

+ signin_metrics::AccessPoint access_point) {

NOTREACHED();

}

void BrowserWindowCocoa::CloseModalSigninWindow() {