chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h

index e6b9d2e481c49deecb4a04a6564cf6bc6850a2dd..5a354b315bd0d6158d278ec1330f29d2bdcf372a 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h

@@ -158,8 +158,10 @@ class BrowserWindowCocoa

override;

void ShowAvatarBubbleFromAvatarButton(

AvatarBubbleMode mode,

- const signin::ManageAccountsParams& manage_accounts_params) override;

- void ShowModalSigninWindow(AvatarBubbleMode mode) override;

+ const signin::ManageAccountsParams& manage_accounts_params,

+ signin_metrics::AccessPoint access_point) override;

+ void ShowModalSigninWindow(AvatarBubbleMode mode,

+ signin_metrics::AccessPoint access_point) override;

void CloseModalSigninWindow() override;

int GetRenderViewHeightInsetWithDetachedBookmarkBar() override;

void ExecuteExtensionCommand(const extensions::Extension* extension,