chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: document signin.signinreason histogram Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_window.h ('K') | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

index c9b8c2b099230c5989de8f27460d851fe7913f10..583e42e5e5dea24d501da7e36ef7e15f8b6ad426 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc

@@ -175,7 +175,9 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTriggeredResetTest,

GURL expected_first_tab_url =

signin::ShouldShowPromoAtStartup(browser()->profile(), true)

- ? signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false)

+ ? signin::GetPromoURL(

+ signin_metrics::AccessPoint::ACCESS_POINT_START_PAGE,

+ signin_metrics::Reason::REASON_SIGNIN_PRIMARY_ACCOUNT, false)

: GURL(chrome::kChromeUINewTabURL);

EXPECT_EQ(expected_first_tab_url, tab_strip->GetWebContentsAt(0)->GetURL());