Implement newly designed sign-in related histograms for desktop platorms.

chrome/browser/ui/browser_window.h

Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index b334c083c5d17408c0ea3d18c63245a7421d58e9..64038ee35c73690a2406bfef379613ed6a62cf27 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -61,6 +61,10 @@ namespace web_modal {
 class WebContentsModalDialogHost;
 }
 
+namespace signin_metrics {

[Bernhard Bauer, 2015/12/07 12:14:54]

Keep the namespaces ordered alphabetically. Also, do you need to specify an
underlying type?

[gogerald1, 2015/12/07 16:45:30]

Done. Specify underlying type to make explicit conversion clear.

[Bernhard Bauer, 2015/12/07 16:49:27]

Well, do we need to repeat this everywhere this enum is forward-declared? It
just seems somewhat redundant, as any place that actually deals with it probably
needs the full definition anyway.

+enum class AccessPoint : int;
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserWindow interface
 //  An interface implemented by the "view" of the Browser window.
@@ -374,6 +378,8 @@ class BrowserWindow : public ui::BaseWindow {
 
   // Shows the avatar bubble on the window frame off of the avatar button with
   // the given mode. The Service Type specified by GAIA is provided as well.
+  // |access_point| indicates the access point used to open the Gaia sign in
+  // page.
   enum AvatarBubbleMode {
     AVATAR_BUBBLE_MODE_DEFAULT,
     AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
@@ -384,11 +390,17 @@ class BrowserWindow : public ui::BaseWindow {
     AVATAR_BUBBLE_MODE_SHOW_ERROR,
     AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
   };
-  virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode,
-      const signin::ManageAccountsParams& manage_accounts_params) = 0;
+  virtual void ShowAvatarBubbleFromAvatarButton(
+      AvatarBubbleMode mode,
+      const signin::ManageAccountsParams& manage_accounts_params,
+      signin_metrics::AccessPoint access_point) = 0;
 
   // Shows the signin flow for |mode| in a tab-modal dialog.
-  virtual void ShowModalSigninWindow(AvatarBubbleMode mode) = 0;
+  // |access_point| indicates the access point used to open the Gaia sign in
+  // page.
+  virtual void ShowModalSigninWindow(
+      AvatarBubbleMode mode,
+      signin_metrics::AccessPoint access_point) = 0;
 
   // Closes the tab-modal signin flow opened with ShowModalSigninWindow, if it's
   // open. Does nothing otherwise.