chrome/browser/ui/browser_command_controller.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: document signin.signinreason histogram Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/signin_promo.cc ('K') | « chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | chrome/browser/ui/browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index b6f7942e3cd4ab6f4c2c7d6d65b241e3039486eb..d17f37aff58887dcb756fa5f2bdceaf3519b3fd3 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -780,7 +780,8 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

ShowHelp(browser_, HELP_SOURCE_MENU);

break;

case IDC_SHOW_SIGNIN:

- ShowBrowserSigninOrSettings(browser_, signin_metrics::SOURCE_MENU);

+ ShowBrowserSigninOrSettings(

+ browser_, signin_metrics::AccessPoint::ACCESS_POINT_MENU);

break;

case IDC_DISTILL_PAGE:

DistillCurrentPage(browser_);