chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/app_launcher_login_handler.cc ('K') | « chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler.h » ('j') | chrome/browser/ui/webui/options/sync_setup_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

index d30cd2e6406f2dd916dd4b7f7e8cc62a72a11a8f..c7cf37c1faffe310d81f1e8cb49dbbe99ca68488 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc

@@ -130,7 +130,7 @@ void NewTabPageSyncHandler::HandleSyncLinkClicked(const base::ListValue* args) {

chrome::FindBrowserWithWebContents(web_ui()->GetWebContents());

if (!browser || browser->IsAttemptingToCloseBrowser())

return;

- chrome::ShowBrowserSignin(browser, signin_metrics::SOURCE_NTP_LINK);

+ chrome::ShowBrowserSignin(browser, signin_metrics::ACCESS_POINT_NTP_LINK);

if (sync_service_->HasSyncSetupCompleted()) {

base::string16 user = base::UTF8ToUTF16(