Implement newly designed sign-in related histograms for desktop platorms.

chrome/browser/ui/webui/app_launcher_login_handler.cc

Index: chrome/browser/ui/webui/app_launcher_login_handler.cc
diff --git a/chrome/browser/ui/webui/app_launcher_login_handler.cc b/chrome/browser/ui/webui/app_launcher_login_handler.cc
index c5cdb440d2d17b81fe5ff23470fd6358e0a92e53..7514a9b5325b098f1c3ee4eb43dd68988064f8ea 100644
--- a/chrome/browser/ui/webui/app_launcher_login_handler.cc
+++ b/chrome/browser/ui/webui/app_launcher_login_handler.cc
@@ -126,11 +126,11 @@ void AppLauncherLoginHandler::HandleShowSyncLoginUI(
     return;
 
   // The user isn't signed in, show the sign in promo.
-  signin_metrics::Source source =
-      web_contents->GetURL().spec() == chrome::kChromeUIAppsURL ?
-          signin_metrics::SOURCE_APPS_PAGE_LINK :
-          signin_metrics::SOURCE_NTP_LINK;
-  chrome::ShowBrowserSignin(browser, source);
+  signin_metrics::AccessPoint access_point =
+      web_contents->GetURL().spec() == chrome::kChromeUIAppsURL
+          ? signin_metrics::ACCESS_POINT_APPS_PAGE_LINK
+          : signin_metrics::ACCESS_POINT_NTP_LINK;
+  chrome::ShowBrowserSignin(browser, access_point);
   RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);
 }
 
@@ -157,10 +157,15 @@ void AppLauncherLoginHandler::HandleLoginMessageSeen(
 
 void AppLauncherLoginHandler::HandleShowAdvancedLoginUI(
     const base::ListValue* args) {
-  Browser* browser =
-      chrome::FindBrowserWithWebContents(web_ui()->GetWebContents());
-  if (browser)
-    chrome::ShowBrowserSignin(browser, signin_metrics::SOURCE_NTP_LINK);
+  content::WebContents* web_contents = web_ui()->GetWebContents();
+  Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
+  if (browser) {

[Bernhard Bauer, 2015/12/04 11:06:24]

Return early if |browser| is null?

[gogerald1, 2015/12/04 20:49:09]

Done.

+    signin_metrics::AccessPoint access_point =
+        web_contents->GetURL().spec() == chrome::kChromeUIAppsURL
+            ? signin_metrics::ACCESS_POINT_APPS_PAGE_LINK
+            : signin_metrics::ACCESS_POINT_NTP_LINK;
+    chrome::ShowBrowserSignin(browser, access_point);
+  }
 }
 
 void AppLauncherLoginHandler::UpdateLogin() {