chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/profiles/profile_chooser_view.h ('K') | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/browser/ui/views/profiles/signin_view_controller.h » ('j') | chrome/browser/ui/views/profiles/user_manager_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

index 23229a497da0a5614eab5e8a086563da0607f5e7..cb175eb82a43cd4706c2ec17c845698a32379c8f 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

@@ -205,7 +205,8 @@ IN_PROC_BROWSER_TEST_F(ProfileChooserViewExtensionsTest,

Browser* browser = CreateBrowser(new_profile);

browser->window()->ShowAvatarBubbleFromAvatarButton(

BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN,

- signin::ManageAccountsParams());

+ signin::ManageAccountsParams(),

+ signin_metrics::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);

ASSERT_FALSE(ProfileChooserView::IsShowing());

CloseBrowserSynchronously(browser);

}