Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2476)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index a4346b0c64c33a2ef1bed0be1e49a9786eba0750..39fe1920ff18980fc8345c8b27ceaa4a215e8ec6 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -1194,7 +1194,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
anchoredAt:(NSPoint)point
viewMode:(profiles::BubbleViewMode)viewMode
tutorialMode:(profiles::TutorialMode)tutorialMode
- serviceType:(signin::GAIAServiceType)serviceType {
+ serviceType:(signin::GAIAServiceType)serviceType
+ accessPoint:(signin_metrics::AccessPoint)accessPoint {
base::scoped_nsobject<InfoBubbleWindow> window([[InfoBubbleWindow alloc]
initWithContentRect:ui::kWindowSizeDeterminedLater
styleMask:NSBorderlessWindowMask
@@ -1209,6 +1210,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
tutorialMode_ = tutorialMode;
observer_.reset(new ActiveProfileObserverBridge(self, browser_));
serviceType_ = serviceType;
+ accessPoint_ = accessPoint;
avatarMenu_.reset(new AvatarMenu(
&g_browser_process->profile_manager()->GetProfileInfoCache(),
@@ -2076,21 +2078,21 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
int messageId = -1;
switch (viewMode_) {
case profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN:
- url = signin::GetPromoURL(signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN,
- false /* auto_close */,
- true /* is_constrained */);
+ url = signin::GetPromoURL(
+ accessPoint_, signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT,
+ false /* auto_close */, true /* is_constrained */);
messageId = IDS_PROFILES_GAIA_SIGNIN_TITLE;
break;
case profiles::BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT:
url = signin::GetPromoURL(
- signin_metrics::SOURCE_AVATAR_BUBBLE_ADD_ACCOUNT,
- false /* auto_close */,
- true /* is_constrained */);
+ accessPoint_, signin_metrics::REASON_ADD_SECONDARY_ACCOUNT,
+ false /* auto_close */, true /* is_constrained */);
messageId = IDS_PROFILES_GAIA_ADD_ACCOUNT_TITLE;
break;
case profiles::BUBBLE_VIEW_MODE_GAIA_REAUTH:
DCHECK(HasAuthError(browser_->profile()));
url = signin::GetReauthURL(
+ accessPoint_, signin_metrics::REASON_REAUTHENTICATION,
browser_->profile(), GetAuthErrorAccountId(browser_->profile()));
messageId = IDS_PROFILES_GAIA_REAUTH_TITLE;
break;

Powered by Google App Engine
This is Rietveld 408576698