chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/chrome_pages.cc ('K') | « chrome/browser/ui/cocoa/profiles/avatar_base_controller.h ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h » ('j') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

index abda2f199ab40adeec091312ab9008fb88be5325..01b31e92df21e42ee29d347dcba038499c482b8c 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

@@ -145,7 +145,8 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

- (void)showAvatarBubbleAnchoredAt:(NSView*)anchor

withMode:(BrowserWindow::AvatarBubbleMode)mode

- withServiceType:(signin::GAIAServiceType)serviceType {

+ withServiceType:(signin::GAIAServiceType)serviceType

+ fromAccessPoint:(signin_metrics::AccessPoint)accessPoint {

if (menuController_) {

profiles::BubbleViewMode viewMode;

profiles::TutorialMode tutorialMode;

@@ -196,7 +197,8 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

anchoredAt:point

viewMode:viewMode

tutorialMode:tutorialMode

- serviceType:serviceType];

+ serviceType:serviceType

+ accessPoint:accessPoint];

[[NSNotificationCenter defaultCenter]

addObserver:self

@@ -220,7 +222,9 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

[self showAvatarBubbleAnchoredAt:button_

withMode:mode

- withServiceType:signin::GAIA_SERVICE_TYPE_NONE];

+ withServiceType:signin::GAIA_SERVICE_TYPE_NONE

+ fromAccessPoint:signin_metrics::

+ ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN];

}

- (IBAction)buttonRightClicked:(id)sender {

@@ -229,7 +233,9 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,