chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/chrome_pages.cc ('K') | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('j') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 63883b009cf46273cc4c37a887f0e669314aa2ec..83fcb6c7a569510ca25e6601f51129410bfaefb7 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -224,8 +224,8 @@ void ExtensionInstalledBubbleBridge::UpdateAnchorPosition() {

clickedOnLink:(id)link

atIndex:(NSUInteger)charIndex {

DCHECK_EQ(promo_.get(), aTextView);

- chrome::ShowBrowserSignin(browser_,

- signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE);

+ chrome::ShowBrowserSignin(

+ browser_, signin_metrics::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE);

return YES;

}