chrome/browser/ui/cocoa/profiles/user_manager_mac.mm - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_commands.cc ('K') | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | chrome/browser/ui/webui/app_launcher_login_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

diff --git a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

index e5bf1c25d50a7d97f1b32c42156725e7f5967ae0..85201387fc740e9c40186fb56fa8964c16364efc 100644

--- a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

+++ b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

@@ -219,7 +219,9 @@ class ReauthDialogDelegate : public UserManager::ReauthDialogObserver,

}

- (void)show {

- GURL url = signin::GetReauthURLWithEmail(emailAddress_);

+ GURL url = signin::GetReauthURLWithEmail(

+ signin_metrics::ACCESS_POINT_USER_MANAGER, signin_metrics::REASON_UNLOCK,

+ emailAddress_);

reauthWebContents_->GetController().LoadURL(url, content::Referrer(),

ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

std::string());