Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index b41962f40e837794bf0813a1b8b50d08fffa01cc..029549201127dfbfa0aded054f495dad5a77cc26 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -17,6 +17,7 @@
#include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/signin/core/browser/signin_header_helper.h"
+#include "components/signin/core/browser/signin_metrics.h"
#include "components/translate/core/common/translate_errors.h"
#include "ui/base/base_window.h"
#include "ui/base/window_open_disposition.h"
@@ -374,6 +375,8 @@ class BrowserWindow : public ui::BaseWindow {
// Shows the avatar bubble on the window frame off of the avatar button with
// the given mode. The Service Type specified by GAIA is provided as well.
+ // |access_point| specifies the access point used to open the Gaia sign in
+ // page.
enum AvatarBubbleMode {
AVATAR_BUBBLE_MODE_DEFAULT,
AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
@@ -384,8 +387,10 @@ class BrowserWindow : public ui::BaseWindow {
AVATAR_BUBBLE_MODE_SHOW_ERROR,
AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
};
- virtual void ShowAvatarBubbleFromAvatarButton(AvatarBubbleMode mode,
- const signin::ManageAccountsParams& manage_accounts_params) = 0;
+ virtual void ShowAvatarBubbleFromAvatarButton(
+ AvatarBubbleMode mode,
+ const signin::ManageAccountsParams& manage_accounts_params,
+ signin_metrics::AccessPoint access_point) = 0;
// Returns the height inset for RenderView when detached bookmark bar is
// shown. Invoked when a new RenderHostView is created for a non-NTP

Powered by Google App Engine
This is Rietveld 408576698