Issue 1473443003: Switch IDB Database.transaction to use a template to do the right type conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1473443003: Switch IDB Database.transaction to use a template to do the right type conversions (Closed)

Created:
5 years ago by Alan Knight

Modified:
5 years ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Switch IDB Database.transaction to use a template to do the right type conversions BUG= Committed: https://github.com/dart-lang/sdk/commit/d2b1388ed1c2d212ee72cc47883c78f0a7ccd5b4

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -76 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	6 chunks	+21 lines, -21 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	2 chunks	+21 lines, -43 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate	View	2 chunks	+23 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Alan Knight

5 years ago (2015-11-23 22:29:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d2b1388ed1c2d212ee72cc47883c78f0a7ccd5b4 (presubmit successful).