Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 1473443003: Switch IDB Database.transaction to use a template to do the right type conversions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/htmlrenamer.py
diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py
index e207e79d836d955cba1d0475380b16e4718918fd..78193a5ea5bd9eae1b79d346fd8f48530432a213 100644
--- a/tools/dom/scripts/htmlrenamer.py
+++ b/tools/dom/scripts/htmlrenamer.py
@@ -439,12 +439,6 @@ renamed_overloads = monitored.Dict('htmldartgenerator.renamed_overloads', {
'DataTransferItemList.add(DOMString data, DOMString type)': 'addData',
'FormData.append(DOMString name, Blob value, DOMString filename)':
'appendBlob',
- 'IDBDatabase.transaction(DOMStringList storeNames, IDBTransactionMode mode)':
- 'transactionStores',
- 'IDBDatabase.transaction(sequence<DOMString> storeNames, IDBTransactionMode mode)':
- 'transactionList',
- 'IDBDatabase.transaction(DOMString storeName, IDBTransactionMode mode)':
- 'transactionStore',
'RTCDataChannel.send(ArrayBuffer data)': 'sendByteBuffer',
'RTCDataChannel.send(ArrayBufferView data)': 'sendTypedData',
'RTCDataChannel.send(Blob data)': 'sendBlob',
@@ -777,6 +771,7 @@ removed_html_members = monitored.Set('htmlrenamer.removed_html_members', [
'HTMLTitleElement.text',
'HTMLUListElement.compact',
'HTMLUListElement.type',
+ 'IDBDatabase.transaction', # We do this in a template without the generated implementation at all.
'Location.valueOf',
'MessageEvent.ports',
'MessageEvent.webkitInitMessageEvent',
« no previous file with comments | « sdk/lib/indexed_db/dartium/indexed_db_dartium.dart ('k') | tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698