Bucket FirstContentfulPaint timing into High/Low res clock buckets

Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA, we can come up with next steps and potentially migrate more histograms to use this model (or allow post-processing filtering).

For now, we will only bucket FirstContentfulPaint, as we think it's our best metric to date.

BUG=394757
Committed: https://crrev.com/16bdd9b85e2bce3fc6aa961241334e4d371b28f4
Cr-Commit-Position: refs/heads/master@{#361241}

[Charlie Harrison, 2015-11-23 19:51:51]

Description was changed from

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows. If filtering by high resolution proves to be an
effective way to de-noise UMA, it should be used in the future.

BUG=394757
==========

to

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows. If filtering by high resolution proves to be an
effective way to de-noise UMA, it should be used in the future.

BUG=394757
==========

[Charlie Harrison, 2015-11-23 19:53:07]

Description was changed from

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows. If filtering by high resolution proves to be an
effective way to de-noise UMA, it should be used in the future.

BUG=394757
==========

to

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA,
we can come up with next steps and potentially migrate more histograms to use
this model (or allow post-processing filtering).

BUG=394757
==========

[Charlie Harrison, 2015-11-23 19:54:25]

Description was changed from

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA,
we can come up with next steps and potentially migrate more histograms to use
this model (or allow post-processing filtering).

BUG=394757
==========

to

==========
Bucket FirstContentfulPaint timing into High/Low res clock buckets

This will hopefully illuminate some of the problems inherent with the low
resolution clock on windows.

If filtering by high resolution proves to be an effective way to de-noise UMA,
we can come up with next steps and potentially migrate more histograms to use
this model (or allow post-processing filtering).

For now, we will only bucket FirstContentfulPaint, as we think it's our best
metric to date.

BUG=394757
==========

[Charlie Harrison, 2015-11-23 19:54:25]

csharrison@chromium.org changed reviewers:
+ asvitkine@chromium.org, bmcquade@chromium.org, rdsmith@chromium.org

[Charlie Harrison, 2015-11-23 19:55:42]

PTAL. Created this CL per our discussion in the uma-team thread about adding
this data to the UMA records. 
Thanks!

[Bryan McQuade, 2015-11-23 20:01:21]

lgtm

[Alexei Svitkine (slow), 2015-11-23 21:01:32]

https://codereview.chromium.org/1473443002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1473443002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:79676: +  <suffix
name="LowResolutionClock"
You can list two suffix entries under the same histogram_suffixes, so please
merge them.

[Charlie Harrison, 2015-11-23 21:20:23]

Thanks!

https://codereview.chromium.org/1473443002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1473443002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:79676: +  <suffix
name="LowResolutionClock"
On 2015/11/23 21:01:32, Alexei Svitkine (slow) wrote:
> You can list two suffix entries under the same histogram_suffixes, so please
> merge them.

Done.

[Alexei Svitkine (slow), 2015-11-23 21:23:14]

lgtm

[Randy Smith (Not in Mondays), 2015-11-23 21:40:38]

So I'm ok with lgtm-ing this as an experiment, but I don't think this is a good
pattern to use going forward for any histogram we care about this difference
with--we'd need a more general solution.  So ok for an experiment, but not ok if
we intend to leave the histogram like this after we see the results.  In the
latter case, please make the argument that this is the right thing long-term and
I'll respond.

[Charlie Harrison, 2015-11-23 21:43:55]

On 2015/11/23 21:40:38, rdsmith wrote:
> So I'm ok with lgtm-ing this as an experiment, but I don't think this is a
good
> pattern to use going forward for any histogram we care about this difference
> with--we'd need a more general solution.  So ok for an experiment, but not ok
if
> we intend to leave the histogram like this after we see the results.  In the
> latter case, please make the argument that this is the right thing long-term
and
> I'll respond.

Yes, it's an experiment. If it's useful for us there are a number of things we
can do to generalize it and spread its helpfulness :)

[Charlie Harrison, 2015-11-23 22:08:49]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2015-11-23 22:08:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmcquade@chromium.org
Link to the patchset: https://codereview.chromium.org/1473443002/#ps20001
(title: "merge histogram suffixes")

[commit-bot: I haz the power, 2015-11-23 22:10:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473443002/20001

[commit-bot: I haz the power, 2015-11-23 23:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:53:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Charlie Harrison, 2015-11-24 01:06:36]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:10:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473443002/20001

[commit-bot: I haz the power, 2015-11-24 03:15:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 03:16:33]

Patchset 2 (id:??) landed as
https://crrev.com/16bdd9b85e2bce3fc6aa961241334e4d371b28f4
Cr-Commit-Position: refs/heads/master@{#361241}