Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1473443002: Bucket FirstContentfulPaint timing into High/Low res clock buckets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge histogram suffixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index c112a7141646455f8da79402c6fdd9cd2bd1b8ec..b9850ec0cfb32bf330b82dd9a5ac0278b4303f24 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -279,6 +279,15 @@ void PageLoadTracker::RecordTimingHistograms() {
if (first_contentful_paint < background_delta) {
PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaint,
first_contentful_paint);
+ // Bucket these histograms into high/low resolution clock systems. This
+ // might point us to directions that will de-noise some UMA.
+ if (base::TimeTicks::IsHighResolution()) {
+ PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintHigh,
+ first_contentful_paint);
+ } else {
+ PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintLow,
+ first_contentful_paint);
+ }
} else {
PAGE_LOAD_HISTOGRAM(kBackgroundHistogramFirstContentfulPaint,
first_contentful_paint);
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698