Invalidate first line display item clients when first line style changes

third_party/WebKit/Source/core/layout/LayoutBlock.h

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h
index d0e54aeba07150cfdeac9ed219b9e472791b3b9e..15f53432c14be15e3e9c7eede45c1a7d64808a83 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h
@@ -276,6 +276,11 @@ public:
     bool recalcChildOverflowAfterStyleChange();
     bool recalcOverflowAfterStyleChange();
 
+    // Obtains the nearest enclosing block (including this block) that contributes a first-line style to our inline children.

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

"Returns the nearest enclosing block (including this block) that contributes a
first-line style to our first line"

[Xianzhu, 2015/12/03 17:38:22]

Done.

+    LayoutBlock* firstLineStyleBlock() const;

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

enclosingFirstLineStyleBlock()?

[Xianzhu, 2015/12/03 17:38:22]

Done.

+    // Returns the descendant block containing the actual first line.

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

Shouldn't this also include this block? I see that the implementation doesn't
include it, but shouldn't it?

[Xianzhu, 2015/12/03 17:38:22]

Yes, it should. Done. Also added a test to cover the case.

+    LayoutBlockFlow* firstLineContainer() const;

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

Not sure if I'm happy with the block vs. container distinction.
nearestInnerBlockWithFirstLine()?

[Xianzhu, 2015/12/03 17:38:22]

Your suggestion sounds better. Done.

+
 protected:
     void willBeDestroyed() override;
 
@@ -396,10 +401,6 @@ private:
 
     void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const;
 
-    // Obtains the nearest enclosing block (including this block) that contributes a first-line style to our inline
-    // children.
-    LayoutBlock* firstLineBlock() const override;
-
     LayoutObject* hoverAncestor() const final;
     void updateDragState(bool dragOn) final;
     void childBecameNonInline(LayoutObject* child) final;