Invalidate first line display item clients when first line style changes

third_party/WebKit/Source/core/layout/LayoutBlock.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 258 matching lines @@
 #if ENABLE(ASSERT)
     void checkPositionedObjectsNeedLayout();
 #endif
 #ifndef NDEBUG
     void showLineTreeAndMark(const InlineBox* = nullptr, const char* = nullptr, const InlineBox* = nullptr, const char* = nullptr, const LayoutObject* = nullptr) const;
 #endif
 
     bool recalcChildOverflowAfterStyleChange();
     bool recalcOverflowAfterStyleChange();
 
+    // Obtains the nearest enclosing block (including this block) that contributes a first-line style to our inline children.

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

"Returns the nearest enclosing block (including this block) that contributes a
first-line style to our first line"

[Xianzhu, 2015/12/03 17:38:22]

Done.

+    LayoutBlock* firstLineStyleBlock() const;

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

enclosingFirstLineStyleBlock()?

[Xianzhu, 2015/12/03 17:38:22]

Done.

+    // Returns the descendant block containing the actual first line.

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

Shouldn't this also include this block? I see that the implementation doesn't
include it, but shouldn't it?

[Xianzhu, 2015/12/03 17:38:22]

Yes, it should. Done. Also added a test to cover the case.

+    LayoutBlockFlow* firstLineContainer() const;

[mstensho (USE GERRIT), 2015/12/03 12:08:10]

Not sure if I'm happy with the block vs. container distinction.
nearestInnerBlockWithFirstLine()?

[Xianzhu, 2015/12/03 17:38:22]

Your suggestion sounds better. Done.

+
 protected:
     void willBeDestroyed() override;
 
     void dirtyForLayoutFromPercentageHeightDescendants(SubtreeLayoutScope&);
 
     void layout() override;
 
     enum PositionedLayoutBehavior {
         DefaultLayout,
         LayoutOnlyFixedPositionedObjects,
@@ skipping 100 matching lines @@
     bool avoidsFloats() const override { return true; }
 
     bool hitTestContents(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction);
     // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to LayoutBlockFlow
     virtual bool hitTestFloats(HitTestResult&, const HitTestLocation&, const LayoutPoint&) { return false; }
 
     virtual bool isPointInOverflowControl(HitTestResult&, const LayoutPoint& locationInContainer, const LayoutPoint& accumulatedOffset) const;
 
     void computeBlockPreferredLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const;
 
-    // Obtains the nearest enclosing block (including this block) that contributes a first-line style to our inline
-    // children.
-    LayoutBlock* firstLineBlock() const override;
-
     LayoutObject* hoverAncestor() const final;
     void updateDragState(bool dragOn) final;
     void childBecameNonInline(LayoutObject* child) final;
 
     bool isSelectionRoot() const;
 
     void absoluteRects(Vector<IntRect>&, const LayoutPoint& accumulatedOffset) const override;
     void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const override;
 
 public:
@@ skipping 76 matching lines @@
     // FIXME: This is temporary as we move code that accesses block flow
     // member variables out of LayoutBlock and into LayoutBlockFlow.
     friend class LayoutBlockFlow;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
 
 } // namespace blink
 
 #endif // LayoutBlock_h