Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1473363002: Revert of Use sysroot by default for all linux builds (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Lei Zhang, Dirk Pranke, Nico
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ ) Reason for revert: Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973 Original issue's description: > Use sysroot by default for all linux builds > > Using a sysroot was already the default for official > build and when cross compiling (e.g. arm, mips, x86-32). > This change makes it the default in all cases. > > The old behavior of building against local > system libraries can still be achieved by > setting use_sysroot=0 > > BUG=504446 > > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d > Cr-Commit-Position: refs/heads/master@{#361197} TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Committed: https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016 Cr-Commit-Position: refs/heads/master@{#361405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -10 lines 0 comments Download
M build/config/sysroot.gni View 2 chunks +12 lines, -8 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 3 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
Created Revert of Use sysroot by default for all linux builds
5 years ago (2015-11-24 18:50:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473363002/1
5 years ago (2015-11-24 18:52:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:56:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016 Cr-Commit-Position: refs/heads/master@{#361405}
5 years ago (2015-11-24 18:57:32 UTC) #4
Sam Clegg
5 years ago (2015-11-24 19:24:41 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1472873004/ by sbc@chromium.org.

The reason for reverting is: Relanding sysroot change.

Powered by Google App Engine
This is Rietveld 408576698