Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 147333004: Revert of Limit the usage of SharedPersistent to ScriptValue only (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert of Limit the usage of SharedPersistent to ScriptValue only (https://codereview.chromium.org/146523002/) Reason for revert: This change seems to be causing failures with plugins on windows 7 build: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13319 The blame is 165731:165767 so this change looks most likely. Original issue's description: > We've replaced SharedPersistent with ScopedPersistent or ScriptValue before, but a couple of SharedPersistents are remaining. So this CL replaces them. > > Ideally we want to remove SharedPersistent though. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165751 TBR=jochen@chromium.org,dcarney@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -56 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/ScopedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptController.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/ScriptValue.h View 3 chunks +4 lines, -33 lines 0 comments Download
A Source/bindings/v8/SharedPersistent.h View 1 chunk +69 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8NPObject.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp View 5 chunks +21 lines, -5 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
Created Revert of Limit the usage of SharedPersistent to ScriptValue only
6 years, 11 months ago (2014-01-25 00:35:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/147333004/1
6 years, 11 months ago (2014-01-25 00:35:43 UTC) #2
commit-bot: I haz the power
Change committed as 165802
6 years, 11 months ago (2014-01-25 00:36:06 UTC) #3
Alpha Left Google
On 2014/01/25 00:36:06, I haz the power (commit-bot) wrote: > Change committed as 165802 Reverting ...
6 years, 11 months ago (2014-01-25 02:12:47 UTC) #4
haraken
6 years, 11 months ago (2014-01-25 14:20:19 UTC) #5
Message was sent while issue was closed.
On 2014/01/25 02:12:47, Alpha wrote:
> On 2014/01/25 00:36:06, I haz the power (commit-bot) wrote:
> > Change committed as 165802
> 
> Reverting this change did clear the failures on interactive_ui_tests.

Sorry about the breakage, and thanks for the revert. I'll investigate.

Powered by Google App Engine
This is Rietveld 408576698