Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: Source/core/html/HTMLPlugInElement.h

Issue 147333004: Revert of Limit the usage of SharedPersistent to ScriptValue only (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInElement.h
diff --git a/Source/core/html/HTMLPlugInElement.h b/Source/core/html/HTMLPlugInElement.h
index b182409e43b28ee218a9ea33d7fb7be89816b2aa..88be9885379fd4906d4462f5f88663895f40b327 100644
--- a/Source/core/html/HTMLPlugInElement.h
+++ b/Source/core/html/HTMLPlugInElement.h
@@ -23,7 +23,7 @@
#ifndef HTMLPlugInElement_h
#define HTMLPlugInElement_h
-#include "bindings/v8/ScriptValue.h"
+#include "bindings/v8/SharedPersistent.h"
#include "core/html/HTMLFrameOwnerElement.h"
struct NPObject;
@@ -45,7 +45,7 @@
virtual ~HTMLPlugInElement();
void resetInstance();
- ScriptValue pluginWrapper();
+ SharedPersistent<v8::Object>* pluginWrapper();
Widget* pluginWidget() const;
NPObject* getNPObject();
bool canProcessDrag() const;
@@ -126,7 +126,7 @@
bool pluginIsLoadable(const KURL&, const String& mimeType);
bool wouldLoadAsNetscapePlugin(const String& url, const String& serviceType);
- mutable ScriptValue m_pluginWrapper;
+ mutable RefPtr<SharedPersistent<v8::Object> > m_pluginWrapper;
NPObject* m_NPObject;
bool m_isCapturingMouseEvents;
bool m_inBeforeLoadEventHandler;
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698