Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: destroy order Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
index 58eebca22a8fb8b653b330b4a782f9ca3ff8dbc6..0465ede23619906d8eefeaae1f945b34c6a43681 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
@@ -11,14 +11,12 @@
class FromGWSPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
- explicit FromGWSPageLoadMetricsObserver(
- page_load_metrics::PageLoadMetricsObservable* metrics);
+ FromGWSPageLoadMetricsObserver();
// page_load_metrics::PageLoadMetricsObserver implementation:
void OnCommit(content::NavigationHandle* navigation_handle) override;
void OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnPageLoadMetricsGoingAway() override;
protected:
// Called in tests.
@@ -27,7 +25,6 @@ class FromGWSPageLoadMetricsObserver
private:
bool navigation_from_gws_;
- page_load_metrics::PageLoadMetricsObservable* const metrics_;
DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
};
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698