Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: destroy order Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index da8046aa770ac281e62ba05efefc51798d0168ef..bccbd593e75d4b8e70201cf7569fb5c68cd7c56b 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -57,9 +57,8 @@ bool ShouldLogEvent(const base::TimeDelta& event,
} // namespace
-FromGWSPageLoadMetricsObserver::FromGWSPageLoadMetricsObserver(
- page_load_metrics::PageLoadMetricsObservable* metrics)
- : navigation_from_gws_(false), metrics_(metrics) {}
+FromGWSPageLoadMetricsObserver::FromGWSPageLoadMetricsObserver()
+ : navigation_from_gws_(false) {}
void FromGWSPageLoadMetricsObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
@@ -116,11 +115,6 @@ void FromGWSPageLoadMetricsObserver::OnComplete(
}
}
-void FromGWSPageLoadMetricsObserver::OnPageLoadMetricsGoingAway() {
- metrics_->RemoveObserver(this);
- delete this;
-}
-
void FromGWSPageLoadMetricsObserver::SetCommittedURLAndReferrer(
const GURL& url,
const content::Referrer& referrer) {

Powered by Google App Engine
This is Rietveld 408576698