Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1473103002: Generate correct error from WEBGL_draw_buffers extension. (Closed)

Created:
5 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
5 years ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate correct error from WEBGL_draw_buffers extension. Should produce INVALID_OPERATION, not INVALID_VALUE, when number of buffers != 1 when default back buffer is bound. BUG=559359 Committed: https://crrev.com/a423527b68fc52203b4b5ba3b2de2f2dc9842f66 Cr-Commit-Position: refs/heads/master@{#361401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Ken Russell (switch to Gerrit)
PTAL
5 years, 1 month ago (2015-11-24 02:11:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473103002/1
5 years, 1 month ago (2015-11-24 02:13:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133364)
5 years, 1 month ago (2015-11-24 04:30:07 UTC) #6
bajones
On 2015/11/24 04:30:07, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years ago (2015-11-24 16:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473103002/1
5 years ago (2015-11-24 18:17:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:49:30 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 18:50:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a423527b68fc52203b4b5ba3b2de2f2dc9842f66
Cr-Commit-Position: refs/heads/master@{#361401}

Powered by Google App Engine
This is Rietveld 408576698